如何解决不能确切地说出这个类是做什么的,它的职责是什么?
所以我有这门课:
public class GeneralService : Idisposable
{
private readonly LoggingService _logginService;
private readonly DataService _dataService;
private readonly IServiceProvider _serviceProvider;
public GeneralService(LoggingService loggingService,DataService dataService,IServiceProvider serviceProvider)
{
_logginService = loggingService;
_dataService = dataService;
_serviceProvider = serviceProvider;
var eventBusProvider = serviceProvider.getService<eventBusProvider>();
eventBusProvider.RegisterForNotification(this,EventTypes.Exception,HandleException);
}
public void dispose()
{
var eventBusProvider = _serviceProvider.GetService<eventBusProvider>();
eventBusProvider.UnRegisterForNotification(this);
}
public void Execute(Action action)
{
LoggingService loggingService = _serviceProvider.GetService<loggingService>();
StopWatch watch = new StopWatch();
watch.Start();
loggingService.Loginformation("Start Executing");
try
{
action();
}
catch (Exception exception)
{
loggingService.LogException(exception);
return;
}
watch.stop();
_dataService.CreateLog($"{nameof(GeneralService)} - {nameof(Execute)}: {watch.ElapsedMillieseconds}");
}
private void HandleException(Exception exception)
{
var loggingService = new LoggingService();
_dataService.CreateLog(exception);
loggingService.Loginformation("Ëxception was logged");
}
}
而且我有两个问题,我无法描述这个类的职责,我不确定如何根据行业最佳实践对其进行重构,任何帮助都会很棒。 提前致谢。
版权声明:本文内容由互联网用户自发贡献,该文观点与技术仅代表作者本人。本站仅提供信息存储空间服务,不拥有所有权,不承担相关法律责任。如发现本站有涉嫌侵权/违法违规的内容, 请发送邮件至 dio@foxmail.com 举报,一经查实,本站将立刻删除。