如何解决java代码异味:我不应该使用可变字符串吗?
我的代码:
private volatile String tokenCache;
private volatile long tokenLastUpdateTimeStamp;
private String getToken() throws IOException {
// cache in 10 minutes.
if (StringUtils.isNotEmpty(tokenCache) && System.currentTimeMillis() - tokenLastUpdateTimeStamp < 10 * 60 * 1000) {
return tokenCache;
}
tokenCache = xxx;
tokenLastUpdateTimeStamp = System.currentTimeMillis();
return tokenCache;
但我在声纳中闻到了代码异味:
Non-primitive fields should not be "volatile"
Marking an array volatile means that the array itself will always be read fresh and never thread cached,but the items in the array will not be. Similarly,marking a mutable object field volatile means the object reference is volatile but the object itself is not,and other threads may not see updates to the object state.
This can be salvaged with arrays by using the relevant AtomicArray class,such as AtomicIntegerArray,instead. For mutable objects,the volatile should be removed,and some other method should be used to ensure thread-safety,such as synchronization,or ThreadLocal storage.
Noncompliant Code Example
private volatile int [] vInts; // Noncompliant
private volatile MyObj myObj; // Noncompliant
Compliant Solution
private AtomicIntegerArray vInts;
private MyObj myObj;
我想问:
我的用法有错吗?我认为我的 tokenCache
不像 myObj
;
版权声明:本文内容由互联网用户自发贡献,该文观点与技术仅代表作者本人。本站仅提供信息存储空间服务,不拥有所有权,不承担相关法律责任。如发现本站有涉嫌侵权/违法违规的内容, 请发送邮件至 dio@foxmail.com 举报,一经查实,本站将立刻删除。